-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[url_launcher]Added webOnlyWindowName parameter to launch() #2979
Conversation
@ditman 2nd pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to merge this on red, to fix the current breakage in the repo (I shouldn't have published platform_interface 1.0.8 so soon)
Merged with most of the checks passed, I'll keep an eye on post-submit checks and merge the new packages ASAP. |
Both url_launcher and url_launcher_web have been published: |
I get this exception since updating to url_launcher 5.5.1
|
@lazylazyllama Maybe try |
Running |
This is using a parameter added in 1.0.8 of the interface package, but didn't rev the dependency in pubspec, which is still 1.0.4. This PR should have set that to 1.0.8. |
* master: [url_launcher, url_launcher_web]Added webOnlyWindowName parameter to launch() (flutter#2979) [battery_platform_interface] Introduce package. (flutter#2975) [url_launcher_platform_interface] Add webOnlyWindowName parameter to launch() (flutter#2974) [share] Add sharing file support (android & ios) (flutter#970) [integration_test] add support to get timeline (flutter#2947) [battery] Moved battery to its own subdir (flutter#2969) [integration_test] Fix channel name for iOS, docs (flutter#2972) [integration_test] Show stack trace of widget test errors on the platform side (flutter#2967) [video_player] Fix `setWithOthers` test (flutter#2970) [video_player_platform_interface] fix `setMixIWithOthers` test channel (flutter#2968) Add README instructions for enablePendingPurchases (flutter#2921) Rebase previous commits (flutter#2966) Avoid walleye 26 Updating documentation to use isEmpty check. (flutter#2955) [integration_test] Minor cleanup (flutter#2956) [path_provider, video_player] Tweak pubspecs to pass bulk analysis. (flutter#2959) [android_intent] fix platform package dep (flutter#2948) [shared_preferences_linux] update `file` package dep version to be compatible with framework (flutter#2950)
5.5.2 should address the issue. Thanks @stuartmorgan for letting me know about the flutter issue! |
Description
Adds the ability to launch a url in same tab,new tab or launch the url in an iframe using webOnlyWindowName parameter
Related Issues
flutter/flutter#56867
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?